GenAI Utils | Embedding Type and Span Creation by shuningc · Pull Request #4219 · open-telemetry/opentelemetry-python-contrib

shuningc · 2026-02-19T17:08:12Z

Description

This PR adds initial embedding lifecycle coverage, to add metrics in the next PR.

Added EmbeddingInvocation support model fields in [types.py] following https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/gen-ai-spans.md#embeddings
Added embedding lifecycle methods in [handler.py]
Added embedding tests in [test_utils.py]
Updated test log exporter usage in [test_utils.py]

Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

How Has This Been Tested?

Ran from repo root with local package path:
PYTHONPATH=util/opentelemetry-util-genai/src pytest -q util/opentelemetry-util-genai/tests/test_utils.py
PYTHONPATH=util/opentelemetry-util-genai/src pytest -q util/opentelemetry-util-genai/tests/test_handler_metrics.py
Results:
[test_utils.py]: 23 passed

Does This PR Require a Core Repo Change?

No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

Followed the style guidelines of this project
Changelogs have been updated
Unit tests have been added
Documentation has been updated

linux-foundation-easycla · 2026-02-19T17:08:19Z

The committers listed above are authorized under a signed CLA.

✅ login: shuningc / name: shuningc (6a9875c, 742812a)

Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>

lmolkova

tried it with with OpenAI instrumentation and left a couple of comments.

Looks good otherwise!

* gen-requirements: stay with virtualenv < 21 No idea what's going on but looks like hatch / hatchling has issues with latest virtualenv 21: Environment `hatch-build` is incompatible: module 'virtualenv.discovery.builtin' has no attribute 'propose_interpreters' * Update gen-requirements.txt Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com> --------- Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>

…lemetry#4246) * fix(threading): attribute error when run is called w/o start * update changelog * don't initialize context on run, fix tests * address styling comments * remove no-op context attachment

…emetry#4253) * [google-genai] Test instrumentation on google-genai v1.63.0 * Add package version upper bound * bump latest version for python 3.9 * fix README * bump google-auth version for python 3.9 * add package upper limit to pyproject.toml * [google-genai] Test instrumentation on google-genai v1.64.0 * fix upper case method in cassette not matching lower case one generated by aiohttp * fix async calls hanging in vcrpy * Remove package upper limit * fix import error in python 3.9 * fix google-genai module lower bound * Add link to vcr issue * Add comment about request method * Fix lint errors * Fix spellcheck --------- Co-authored-by: Aaron Abbott <aaronabbott@google.com>

lmolkova

Let's make sure we don't throw in instrumentation code and also, can we avoid having start_{type}, end_{type}, fail_{type} - we can just have start, stop, fail for all of them

…ypes

shuningc · 2026-03-19T14:06:52Z

Let's make sure we don't throw in instrumentation code and also, can we avoid having start_{type}, end_{type}, fail_{type} - we can just have start, stop, fail for all of them

Langchain, anthropic and openai_v2 instrumentation all have called the start_llm, fail_llm and stop_llm methods. So I prefer to keep these for now and same for embedding type right now. If we want to remove them all later we can create a separate ticket.

lmolkova

LGTM with a caveat around removing stop|fail_embedding methods

…lemetry-api version to 1.39

shuningc requested a review from a team as a code owner February 19, 2026 17:08

github-actions Bot assigned DylanRussell Feb 19, 2026

aabmass marked this pull request as draft February 19, 2026 17:19

nagkumar91 reviewed Feb 19, 2026

View reviewed changes

Comment thread util/opentelemetry-util-genai/CHANGELOG.md Outdated

nagkumar91 reviewed Feb 19, 2026

View reviewed changes

Comment thread util/opentelemetry-util-genai/README.rst Outdated

nagkumar91 reviewed Feb 19, 2026

View reviewed changes

Comment thread util/opentelemetry-util-genai/src/opentelemetry/util/genai/span_utils.py Outdated

etserend suggested changes Feb 19, 2026

View reviewed changes

Comment thread util/opentelemetry-util-genai/src/opentelemetry/util/genai/types.py Outdated

Comment thread util/opentelemetry-util-genai/src/opentelemetry/util/genai/types.py Outdated

Comment thread util/opentelemetry-util-genai/src/opentelemetry/util/genai/handler.py

shuningc changed the title ~~[WIP] GenAI Utils | Embedding Type and Span Creation~~ GenAI Utils | Embedding Type and Span Creation Feb 23, 2026

shuningc marked this pull request as ready for review February 23, 2026 16:04

keith-decker reviewed Feb 23, 2026

View reviewed changes

Comment thread util/opentelemetry-util-genai/src/opentelemetry/util/genai/span_utils.py

Comment thread util/opentelemetry-util-genai/src/opentelemetry/util/genai/types.py Outdated

shuningc added 5 commits February 25, 2026 09:08

Add embedding invocation type

f8656f0

pre-commit fix

69d5598

Reverting unnecessary changes and dealing with comments

c202f8b

Dealing with comments

a799410

Refactoring to remove duplicate codes

e16f49f

shuningc force-pushed the adding-embedding-type branch from 4b4e710 to e16f49f Compare February 25, 2026 17:09

github-actions Bot assigned lmolkova Feb 25, 2026

Moving common attributes to GenAIInvocation

3a4577c

tammy-baylis-swi added this to Python PR digest Feb 25, 2026

tammy-baylis-swi moved this to Ready for review in Python PR digest Feb 25, 2026

xrmx reviewed Mar 2, 2026

View reviewed changes

Comment thread util/opentelemetry-util-genai/CHANGELOG.md

Comment thread util/opentelemetry-util-genai/pyproject.toml Outdated

Comment thread util/opentelemetry-util-genai/src/opentelemetry/util/genai/types.py

zhirafovod reviewed Mar 2, 2026

View reviewed changes

Comment thread util/opentelemetry-util-genai/src/opentelemetry/util/genai/types.py Outdated

zhirafovod reviewed Mar 2, 2026

View reviewed changes

Comment thread util/opentelemetry-util-genai/src/opentelemetry/util/genai/types.py Outdated

Apply suggestion from @xrmx

8e388c0

Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>

lmolkova reviewed Mar 3, 2026

View reviewed changes

Comment thread util/opentelemetry-util-genai/src/opentelemetry/util/genai/handler.py Outdated

Comment thread util/opentelemetry-util-genai/src/opentelemetry/util/genai/types.py

nagkumar91 mentioned this pull request Mar 3, 2026

REQUEST: New membership for nagkumar91 open-telemetry/community#3304

Closed

6 tasks

xrmx and others added 3 commits March 5, 2026 06:28

fix(threading): attribute error when run is called w/o start (open-te…

c969470

…lemetry#4246) * fix(threading): attribute error when run is called w/o start * update changelog * don't initialize context on run, fix tests * address styling comments * remove no-op context attachment

shuningc added 2 commits March 12, 2026 08:52

Fixing failed tests out of dependencies and typo

28a7d93

Fixing failed tests by splitting large files and updating dependencies

3a9045d

lmolkova reviewed Mar 12, 2026

View reviewed changes

Comment thread instrumentation-genai/opentelemetry-instrumentation-anthropic/tests/requirements.oldest.txt

shuningc added 4 commits March 12, 2026 12:36

Keeping only generic start,stop and fail methods for all invocation t…

9b78bc2

…ypes

Simplified error type calculation and refactor tests

1e5f50c

Merge branch 'main' into adding-embedding-type

0238075

Merge branch 'main' into adding-embedding-type

f7415f8

etserend approved these changes Mar 17, 2026

View reviewed changes

Reverting start_[type] methods removals, fixing some related tests

dbce15f

lmolkova approved these changes Mar 19, 2026

View reviewed changes

keith-decker mentioned this pull request Mar 19, 2026

Genai utils | Add AgentInvocation type #4274

Merged

10 tasks

lmolkova mentioned this pull request Mar 19, 2026

Add support for workflow invocation in genAI utils #4334

Closed

shuningc added 4 commits March 19, 2026 11:44

Removing start_embedding, stop_embedding and fail_embedding methods

a58b540

Adding one missing change

6dfa5f0

Merge branch 'main' into adding-embedding-type

6684f5a

ruff format fix

c5eb2f5

nagkumar91 approved these changes Mar 19, 2026

View reviewed changes

Merge branch 'main' into adding-embedding-type

0b93488

xrmx reviewed Mar 20, 2026

View reviewed changes

Comment thread util/opentelemetry-util-genai/CHANGELOG.md Outdated

Adding one format fix

c5bb5c6

Cirilla-zmh approved these changes Mar 23, 2026

View reviewed changes

Cirilla-zmh mentioned this pull request Mar 23, 2026

GenAI Utils | Add _BaseAgent base class and agent creation lifecycle #4217

Closed

9 tasks

Merge branch 'main' into adding-embedding-type

7aae7e3

keith-decker mentioned this pull request Mar 24, 2026

GenAI Utils | Add support for ToolCall Invocations #4356

Closed

11 tasks

shuningc added 2 commits March 25, 2026 13:45

Merge branch 'main' into adding-embedding-type

6a9875c

Reverting opentelemetry-instrumentation version to 0.60b.0 and opente…

742812a

…lemetry-api version to 1.39

lzchen merged commit 195bcdb into open-telemetry:main Mar 26, 2026
860 checks passed

github-project-automation Bot moved this from Approved PRs that need fixes to Done in Python PR digest Mar 26, 2026

Conversation

shuningc commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Does This PR Require a Core Repo Change?

Checklist:

Uh oh!

linux-foundation-easycla Bot commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lmolkova left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lmolkova left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shuningc commented Mar 19, 2026

Uh oh!

lmolkova left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

shuningc commented Feb 19, 2026 •

edited

Loading

linux-foundation-easycla Bot commented Feb 19, 2026 •

edited

Loading